Pdf rendering fixes - #87
Open
Nycto wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change contains a few fixes for PDF rendering:
Scripts without a title page rendered at the wrong width. The switch
to the script frame only ever fired for documents with a title page, so title-less scripts rendered in the 5.5" title
frame instead of the 6.1" script frame.
Parentheticals ran to 4.8" instead of 2.5". parenthentical_style set no rightIndent so they were
bounded only by the frame edge and ran wider than the dialogue they annotate.
Dual columns with parentheticals weren't getting rendered correctly
The right-hand scene number sat in the text column, not the margin